Ros-humble-rmf-all virtual package to install all the rmf related packages (#269)

Open-RMF Open-RMF General
1

Posted by @orensbruli:

We previously used rmf-demos for this because it depends on all the other rmf packages but maybe it’s useful to have this kind of virtual package to be able to install rmf without the need to install the demos (which are currently not available in packages).

Not sure that -all should be the suffix for this package. It’s open to suggestions

Edited by @orensbruli at 2022-11-14T09:33:45Z

2

Posted by @aaronchongth:

What about just ros-humble-rmf and ros-humble-rmf-simulation? That’ll mean 2 meta packages, with the first being all the core packages, while the latter installing the core packages as well as anything sim related

3

Posted by @orensbruli:

ros-humble-rmf It sounds good to me.

4

Posted by @orensbruli:

What about the repo for this meta-package? open-rmf/rmf itself?

5

Posted by @aaronchongth:

That would be my first intuition. I’m not familiar with the build farm efforts though, but as a sanity check, would it interfere with anything on that end?

6

Posted by @aaronchongth:

Since the .repos files are hosted there too

7

Posted by @marcoag:

I would advise to follow the ros2 model and create a variants repo: GitHub - ros2/variants: Variants for ROS 2 (implemented as ament packages). It would keep thing cleaner as each repo will have its own purpose. I also foresee different meta packages being useful at different points in the future i.e. -full, -common, -demos, -deployment…

8

Posted by @orensbruli:

The variants templates look like a great option to me.

Edited by @orensbruli at 2022-11-16T05:06:25Z

9

Posted by @orensbruli:

I write a first suggestion of meta-packages and packages that those would install (used bold for new packages):

  • rmf_simulation_all (not sure what could be needed for, needs meta-package)

    • rmf_simulation_gazebo_classic_plugins (needs meta-package)
      • rmf_robot_sim_gz_classic_plugins
      • rmf_building_sim_gz_classic_plugins
    • rmf_simulation_gazebo_plugins (needs meta-package)
      • rmf_building_sim_gz_plugins
      • rmf_robot_sim_gz_plugins

  • rmf_visualization (own repo) (meta-package already exists)

    • rmf_visualization_building_systems
    • rmf_visualization_fleet_states
    • rmf_visualization_floorplans
    • rmf_visualization_navgraphs
    • rmf_visualization_obstacles
    • rmf_visualization_rviz2_plugins
    • rmf_visualization_schedule

  • rmf_ros2 (own repo) (needs meta-package)

    • rmf_fleet_adapter
    • rmf_fleet_adapter_python
    • rmf_task_ros2
    • rmf_traffic_ros2
    • rmf_websocket

  • rmf_internal_msgs (own repo) (needs meta-package)

    • rmf_charger_msgs
    • rmf_dispenser_msgs
    • rmf_door_msgs
    • rmf_fleet_msgs
    • rmf_ingestor_msgs
    • rmf_lift_msgs
    • rmf_obstacle_msgs
    • rmf_scheduler_msgs
    • rmf_site_map_msgs
    • rmf_task_msgs
    • rmf_traffic_msgs
    • rmf_workcell_msgs

And these ones try to reproduce what we had with rmf_demos:

  • rmf-gazebo[-classic]
    • rmf_visualization
    • rmf_simulation_gazebo[_classic]_plugins
    • rviz

Any other meta-package? Any suggestions on different names? Is any of the suggested irrelevant or unuseful?